fix small spelling mistake in generics-type-classes #457
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wookietreiber
approved these changes
Oct 14, 2025
orangecms
suggested changes
Oct 27, 2025
There was a problem hiding this comment.
This is no spelling mistake:
"lest" means to prevent something from happening; in this instance, we refrain from making the module pub, preventing possible mistakes people could make outside our control.
Admittedly, it is a word that non-native speakers may not understand.
I think this is a good call to change the wording:
Keep the module private to prevent outside users from inventing their own protocols.
orangecms
reviewed
Oct 27, 2025
| } | ||
|
|
||
| // private module, lest outside users invent their own protocol kinds! | ||
| // private module, lets outside users invent their own protocol kinds! |
There was a problem hiding this comment.
Suggested change
| // private module, lets outside users invent their own protocol kinds! | |
| // Keep the module private to prevent outside users from inventing their own protocols. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.